Skip to content

Lef/everparse absolute fix#4153

Closed
elefthei wants to merge 2 commits intofstar2from
lef/everparse-absolute-fix
Closed

Lef/everparse absolute fix#4153
elefthei wants to merge 2 commits intofstar2from
lef/everparse-absolute-fix

Conversation

@elefthei
Copy link
Copy Markdown

No description provided.

The all_fstar_files_in_dir function was unconditionally recursing into
all subdirectories when --dep was given a directory argument. This
changes it to use Find.expand_include_d, which only recurses into
subdirectories listed in fstar.include files.

Without fstar.include, only F* files in the immediate directory are
found. With fstar.include, only the listed subdirectories are traversed
(matching the existing behavior of the include path mechanism).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@elefthei elefthei requested a review from tahina-pro March 31, 2026 23:01
@mtzguido mtzguido changed the base branch from master to fstar2 March 31, 2026 23:29
@tahina-pro
Copy link
Copy Markdown
Member

Thanks Lef! This probably solves the fstar.include issue (but EverParse does not use fstar.include, so I let others confirm.)
But this still does not solve the absolute vs. relative path issue, I still encounter it on EverParse fstar2.

Add Filepath.make_relative_to_cwd to convert absolute paths to
paths relative to the current working directory. Use it in
print_full's norm_path so that .depend files contain portable
relative paths instead of machine-specific absolute paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@elefthei elefthei closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants